ggtracker / ggtracker/sc2reader

Incorrect time for string representation of events for LOTV replays

Open
#130 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
169
Forks
152
PR merge metrics
No merged PRs in 30d

Description

This is kind of a non-issue but the string representation for events for LOTV replays seem incorrect.
I parsed a replay that was 11:54 long, but the events go up to 16:25.

Origin of 'bug'

https://github.com/ggtracker/sc2reader/blob/4c6703742094103842a9de827fd4a051e6cf7977/sc2reader/events/game.py#L51

Solution proposal

The frames have to be divided by 22.4 instead of by 16. But this fix only works for LOTV replays, it would again show the wrong time for WOL and HOTS replays.

PS:
I want to let you know that your repository / fork cannot be searched through the github-repository search function (e.g. cant search for class names). This is simply because it is a fork.
If you want to change that and remove the fork-link, you can write a short support ticket to github to lift the connection and it becomes searchable.
Also, google search results don't seem to show this repo when searching for ggtracker sc2reader - unsure why this is (it works in the search engine duckduckgo.com).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at sc2reader/events/game.py around line 51, where the event string time is derived from replay frames. Verify the timing against the reported LOTV replay and determine how the representation can be corrected for LOTV without introducing incorrect times for WOL and HOTS replays.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.