ggtracker / ggtracker/sc2reader
SC2READER_CACHE_MAX_SIZE should be a string, not an integer
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 169
- Forks
- 152
- PR merge metrics
- No merged PRs in 30d
Description
The example (in the readme) suggests to write os.environ['SC2READER_CACHE_MAX_SIZE'] = 100. This does not work (at least for me, Python 3.6.9) : environment variables are supposed to be strings (throws a TypeError).
When set to string, this causes an error in sc2reader because of a comparison between a string and an integer (sc2factory.py line 315).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the README example for SC2READER_CACHE_MAX_SIZE and sc2factory.py line 315. Reproduce the Python 3.6.9 environment-variable assignment and the comparison using a string value; done means the documented configuration and sc2reader handling no longer raise the reported TypeError or string/integer comparison error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100