getsops / getsops/sops

Error when trying to use AzureChinaCloud SOPS key

Open
#862 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
23.1k
Forks
1.1k
Avg merge
1d 11h
Merged PRs (30d)
9

Description

https://github.com/mozilla/sops/blob/38b25bd449619e1d6da20e637702f7c73203aa44/azkv/keysource.go#L54-L90

Hello, referring to https://github.com/Azure/azure-cli/issues/16729

When you don't have the variable AZURE_ENVIRONMENT set as environment variable, you won't get a warning that the AZURE_ENVIRONMENT variable is not set IF the resource searched does not exist.

Would be nice to have this warning to make people save some time.

PS: jiasli suggested to use standard WWW-authenticate for keyvault HERE

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in azkv/keysource.go around lines 54-90 and compare the behavior described in Azure CLI issue 16729. Reproduce an AzureChinaCloud lookup with AZURE_ENVIRONMENT unset and a nonexistent resource; done means the missing environment warning is surfaced instead of being hidden.

Written by the indexing model from the issue text.

Assessment

Tech stack
azure, go
Domain
cli, cloud, security
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.