`updatekeys` should trigger on `shamir_threshold` change
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- Go
- Stars
- 23.1k
- Forks
- 1.1k
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 9
Description
When using groups to split a key using shamir secret sharing, modifying a key in any group in .sops.yaml will cause the file to be reencrypted after running updatekeys. The same is not true when changing the shamir_threshold option in .sopsyaml. Do you think it'd make sense for this to also trigger reencryption?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the updatekeys entry point and comparing how changes to group keys are detected with how shamir_threshold is handled. Confirm the expected behavior with the existing issue discussion, then add coverage showing that changing shamir_threshold in .sops.yaml causes re-encryption when updatekeys runs.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- cli, security
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100