Vault path configuration for publish
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 23.1k
- Forks
- 1.1k
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 9
Description
When I try to publish to Vault, it publishes secrets to this path ${kvMountName}${vaultPath}${fileName} resulting in eg. secret/appName/secrets.qa.yaml . The problem is I would like it to be secret/appName (without the filename at the end).
I understand why there is a filename for GCS and S3 (because you upload file to a storage). However for Vault I have a use-case where I want to upload all app's secrets to this path secret/appName
Would you consider accepting a PR to add a new setting into Vault's destination rule called vault_path_omit_filename which is false by default so there is no breaking change. And if it's set to true it will omit filename in Vault path
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the Vault destination-rule parsing and publish path code, then trace how the filename is appended. Add coverage for the opt-in setting and verify that the default preserves the current path while enabling it produces the configured app path without the filename.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- devops, security
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100