json decoding does not seem to properly respect character encoding
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 23.1k
- Forks
- 1.1k
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 9
Description
Hello,
I'm using sops 3.2.0 with gcp kms. I noticed that decrypting using json input type does not respect (decode) the keys and values' text encoding.
It is easy to reproduce for the '&' character (https://www.fileformat.info/info/unicode/char/0026/index.htm):
'testing1' file contents
{
"key&?abcd":"value?p1=true&p2=false"
}
Encrypt as a json input type file and a binary input file
sops --encrypt --input-type=json --output-type=json --gcp-kms projects/someproject/locations/global/keyRings/sops/cryptoKeys/sops-key testing1 > testing1.json.enc
sops --encrypt --input-type=raw --output-type=raw --gcp-kms projects/someproject/locations/global/keyRings/sops/cryptoKeys/sops-key testing1 > testing1.raw.enc
Decrypt the raw encrypted version (ok)
sops -d --input-type=raw --output-type=raw testing1.raw.enc
{
"key&?abcd":"value?p1=true&p2=false"
}
Decrypt the json encrypted version (not ok)
sops -d --input-type=json --output-type=json testing1.json.enc
{
"key\u0026?abcd": "value?p1=true\u0026p2=false"
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue with the provided sops commands and compare JSON input/output with the raw encryption path. Done means JSON decryption preserves the literal '&' characters in keys and values instead of emitting escaped Unicode sequences.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- gcp, go
- Domain
- cli, security
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100