getsops / getsops/sops

updatekeys subcommand: allow to use shamir_threshold from configuration

Open
#1,610 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area/CLI enhancement
Dominant language
Go
Stars
23.1k
Forks
1.1k
Avg merge
1d 11h
Merged PRs (30d)
9

Description

updatekeys doesn't imply that it updates other things from .sops.conf (see the discussion https://github.com/getsops/sops/pull/1509#discussion_r1623288498), so how about making this behavior configurable? I.e. allow the user to say that they want the Shamir threshold from .conf.sops being used, or that they want to keep it (if not explicitly overridden on CLI).

Ref: #1609
Ref: #1509

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the updatekeys subcommand and its configuration handling, then read the discussion in #1609 and pull request #1509. Determine how an explicit CLI threshold should interact with the configuration value, and consider how the opt-in behavior should be exposed. Done means updatekeys has the requested configurable Shamir-threshold behavior with coverage for configuration and CLI overrides.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli, security
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.