getsops / getsops/sops

Quotation Marks in INI-files

Open
#1,219 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
23.1k
Forks
1.1k
Avg merge
1d 11h
Merged PRs (30d)
9

Description

Hi everyone and first of all: thanks for the amazing work.

The issue I'm having is like that in #760, but this time with regard to INI-files. When I encrypt a string that is enclosed in quotation marks, the quotation marks are gone after decryption. This makes a difference regarding PHP's parse_ini_*-functions, which will accept, e.g., exclamation marks only within quotation marks. Since there apparently is no real INI-standard, they also are well within their rights to handle it like that, apparently.

While the problem can be mitigated by adjusting the scanner mode the functions use, this is not an attractive solution if the call to the function is buried somewhere inside of framework code. It seems to me that it would be best if sops reproduced the entered text verbatim, if that should be an option.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no repository files or tests; start by reproducing the reported loss of quotation marks when encrypting and decrypting an INI value. Check how an optional verbatim-preservation behavior would interact with PHP parse_ini_* functions, and consider the work done when quoted input can be preserved without breaking existing INI handling.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, php
Domain
security
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.