path_regex doesn't normalize paths with filepath.ToSlash
Open
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 23.1k
- Forks
- 1.1k
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 9
Description
Currently to support path_regexes that should work on windows and other systems you need to manually handle the different separators with (/|\\) like this.
- path_regex: staging(/|\\).*\.secret\.(yaml|json)$
gcp_kms: projects/.../sops-key-staging
This is a bit cumbersome and a bit error prone to use and would be nicer if we could just use slashes like this:
- path_regex: staging/.*\.secret\.(yaml|json)$
gcp_kms: projects/.../sops-key-staging
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the code that evaluates path_regex and checking how paths are passed to matching; the issue specifically points to filepath.ToSlash as the relevant Go behavior. Done means a pattern using forward slashes matches equivalent paths on Windows and other systems without requiring (/|\).
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- cli, security
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100