Feedback alert preview doesn't respect project settings
- Dominant language
- Python
- Stars
- 44.8k
- Forks
- 4.9k
- Avg merge
- 22h 21m
- Merged PRs (30d)
- 586
Description
### Environment
SaaS (https://sentry.io/)
### Steps to Reproduce
1. Go to project settings and ensure that "Enable Crash Report Notifications" is toggled off
2. Create an alert rule that triggers when the issue type is "Feedback"
### Expected Result
The preview should not show user feedback registered through the crash report modal.
### Actual Result
The preview shows user feedback that is registered through the crash report modal. While we do point out in that page the message:
> This issue category condition is ONLY for feedback from the [built-in widget](https://docs.sentry.io/platforms/javascript/user-feedback/#user-feedback-widget). [Crash-report modal](https://docs.sentry.io/platforms/javascript/user-feedback/#crash-report-modal) alerts can be enabled in Project Settings.
The preview can draw the customer's attention away from it and make them think that crash modal feedback will trigger this alert rule out-of-the-box.
### Product Area
Alerts
### Link
_No response_
### DSN
_No response_
### Version
_No response_
Contributor guide
Research direction
Start with the alert rule preview and the project setting for "Enable Crash Report Notifications," then trace how feedback from the crash-report modal is included in the preview. Done means the preview excludes crash-report modal feedback when that project setting is off, while preserving the documented widget behavior.
Written by the indexing model from the issue text.
Assessment
- Domain
- observability-sre
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100