getsentry / getsentry/sentry

Repeated Filter Effects Query Hashing

Open
#98,656 2 comments 0 reactions 0 assignees View on GitHub
Improvement Issues > Grouping
Dominant language
Python
Stars
44.8k
Forks
4.9k
Avg merge
22h 21m
Merged PRs (30d)
586

Description

### Environment

SaaS (https://sentry.io/)

### Steps to Reproduce

Customer has two N+1 performance issues that appear almost identical, except the preceding DB span has more repetitions of the same filter thus influencing the grouping and causing confusion.

### Expected Result

Repeating filters do not impact query hashing

### Actual Result

Repeating filters cause seemingly identical N+1 issues to be grouped separately

### Product Area

Unknown

### Link

_No response_

### DSN

_No response_

### Version

_No response_

Contributor guide

Open the contributing guide

Research direction

Start by tracing the query hashing and grouping path responsible for N+1 performance issues, then reproduce the behavior with equivalent filters repeated different numbers of times. Done means repeated filters no longer change the hash, so otherwise identical N+1 issues are grouped together.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
performance
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.