getsentry / getsentry/sentry

Require confirmation for all settings changes as a super user

Open
#93,100 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
44.8k
Forks
4.9k
Avg merge
22h 21m
Merged PRs (30d)
586

Description

### Problem Statement

Spin out of https://github.com/getsentry/sentry/issues/45703

As a technical support staff it can be dangerous to accidentally change a customers settings. We should enforce ALL settings require an explicit "save" action, instead of using the `saveOnBlur: true` feature of most of our forms.

### Solution Brainstorm

If we detect an active super user accessing an org they're not part of, the form system can enforce `saveOnBlur: false` for all form fields.

### Product Area

Unknown

Contributor guide

Open the contributing guide

Research direction

Start by locating the form system and the existing saveOnBlur usage across settings forms. Trace how an active super user accessing an organization they do not belong to is identified, then define tests showing that all fields require an explicit save action in that case.

Written by the indexing model from the issue text.

Assessment

Domain
frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.