getsentry / getsentry/sentry

[Grouping]: Mark Swift Cocoa SDK frames as non in app

Open
#90,290 0 comments 0 reactions 0 assignees View on GitHub
Bug Platform: Cocoa
Dominant language
Python
Stars
44.8k
Forks
4.9k
Avg merge
22h 21m
Merged PRs (30d)
586

Description

Frames of `SentrySRDefaultBreadcrumbConverter` are marked as in app although they should be non in app; see [Example event](https://kula-app.sentry.io/issues/6559294086/?project=5966520). We must double check the in app rules for all Swift classes from the Cocoa SDK.

https://github.com/getsentry/sentry/blob/master/src/sentry/grouping/enhancer/enhancement-configs/newstyle%402023-01-11.txt#L87

Contributor guide

Open the contributing guide

Research direction

Start by reading src/sentry/grouping/enhancer/enhancement-configs/newstyle@2023-01-11.txt around line 87 and compare the rule affecting SentrySRDefaultBreadcrumbConverter. Then review the in-app rules for the other Swift classes from the Cocoa SDK. Done means the affected Cocoa SDK frames are consistently classified as non-in-app, with the reported example corrected.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
backend, observability-sre
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.