getsentry / getsentry/sentry

Improve CODEOWNERS code mapping creation flow

Open
#75,368 0 comments 0 reactions 0 assignees View on GitHub
Improvement
Dominant language
Python
Stars
44.8k
Forks
4.9k
Avg merge
22h 21m
Merged PRs (30d)
586

Description

Steps:

- The customer goes to ownership rules
- since they have source code integrations they can click on "Import CODEOWNERS" [1]
- they pick their integration [2]
- they're redirected to the code mappings tab [3]
- they manually enter the values and hit save

Issues noticed:
- No validation is made if the values are correct and there's a CODEOWNERS
- If the values are incorrect the ownership rules will be empty [4]
- In my case, I picked `master` instead of `develop`
- The customer should have picked (`foo/`, ` `) but they chose (` `, `bar/`) which caused
- Auto assignment did not work
- Stack trace links did not work

[1]
![Image](https://github.com/user-attachments/assets/a5d606ca-0417-4b5e-92e9-0321bffba7ef)

[2]
![Image](https://github.com/user-attachments/assets/ccbbaaca-b230-4925-982b-332831eb1ad1)

[3]
![Image](https://github.com/user-attachments/assets/0d12457b-5b7d-4f20-a809-9fc47bf43844)

[4]
![Image](https://github.com/user-attachments/assets/18b1f0f7-c171-4e70-bf85-61dcf02b29a3)

[5]
![Image](https://github.com/user-attachments/assets/73aa4503-a2d8-40da-aeb5-22031cee5325)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.