getsentry / getsentry/sentry

[grouping info] Description of rule used doesn't always match rule

Open
#72,435 0 comments 0 reactions 1 assignee Claimed by @lobsterkatie View on GitHub
Improvement
Dominant language
Python
Stars
44.8k
Forks
4.9k
Avg merge
22h 21m
Merged PRs (30d)
586

Description

In the Grouping Info section of the issue details page, we tell you what rule caused us to make a given stacktrace modification, which is helpful in theory, but can be confusing, because we don't actually show you the actual rule, but a modified description thereof. For example, this explanation in the UI

![image](https://github.com/getsentry/sentry/assets/14812505/739d7d73-64d1-4fbb-ad3c-109d152bb23b)

came from this rule in the user's project settings

![image](https://github.com/getsentry/sentry/assets/14812505/cebae8ab-e80f-4b79-a9f2-7954ef4555b0)

We should quote the rule itself. (Relevant code is [here](https://github.com/getsentry/sentry/blob/69d4de691f721930b80ab96be5e3a21b01e967d9/src/sentry/grouping/enhancer/actions.py#L119-L129).)

(Note that this isn't always a problem. The descriptions from from this correspondence, and in many cases they do match:

https://github.com/getsentry/sentry/blob/69d4de691f721930b80ab96be5e3a21b01e967d9/src/sentry/grouping/enhancer/matchers.py#L49-L70

But in cases where they don't, it'd be clearer to both the users and us if we were to use the actual text of the rule.)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.