getsentry / getsentry/sentry

Time outs do not create issues

Open
#59,431 14 comments 0 reactions 1 assignee Assigned to @wedamija View on GitHub
Feature Product Area: Crons Sync: Jira
Dominant language
Python
Stars
44.8k
Forks
4.9k
Avg merge
1d 5h
Merged PRs (30d)
624

Description

### Environment

SaaS (https://sentry.io/)

### Steps to Reproduce

For testing purposes:
1. Set up a cron monitor for a 3 minute interval, 5 minute grace period and 7 minute max runtime, and set it to notify your email
2. Use postman and [this endpoint](https://docs.sentry.io/api/crons/create-a-new-checkin/) to create an `in_progress` checkin
![image](https://github.com/getsentry/sentry/assets/81985895/4ce0d14a-6e01-4782-86fa-ae758499776d)

3. Wait until the In Progress status turns to Timed Out [in the Sentry Web UI](https://dragonfruit-dev.sentry.io/crons/1340-5y/?project=4504490632871936&statsPeriod=90d)

### Expected Result

After 7 minutes the checkin should be marked as Timed Out, create an issue, and notify your email.

### Actual Result

No issue is created due to the time out, and no email notification is sent. This has caused a customer to miss a multi-hour failure.

I also tested the same thing with missed and failed checkins, both of which seem to be creating new issues and sending an email. If we mark those issues as resolved, and test the same situations again, the issues will be marked as regressed, so this part works fine.

Links from my test org:
- [monitor](https://dragonfruit-dev.sentry.io/crons/1340-5y/edit/)
- [missed checkin issue](https://dragonfruit-dev.sentry.io/issues/4605859670/?project=4504490632871936&query=is%3Aunresolved&referrer=issue-stream&statsPeriod=90d&stream_index=0)
- [failed checkin issue](https://dragonfruit-dev.sentry.io/issues/4605897020/?project=4504490632871936&query=is%3Aunresolved&referrer=issue-stream&statsPeriod=90d&stream_index=1)

Links to the customer's org are provided in the shadow ticket.

### Product Area

Crons

### Link

_No response_

### DSN

_No response_

### Version

_No response_

┆Issue is synchronized with this [Jira Improvement](https://getsentry.atlassian.net/browse/FEEDBACK-1980) by [Unito](https://www.unito.io)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.