getsentry / getsentry/sentry

Incomplete internal integration audit logs

Open
#51,993 3 comments 0 reactions 0 assignees View on GitHub
Bug Product Area: Settings - Integrations
Dominant language
Python
Stars
44.8k
Forks
4.9k
Avg merge
1d 5h
Merged PRs (30d)
624

Description

### Environment

SaaS (https://sentry.io/)

### Steps to Reproduce

1. Create a new internal integration
2. Add and remove auth-tokens in this integration
3. Remove the integration

### Expected Result

All operations to be recorded in the audit logs. Specially the auth-token add and removal.

### Actual Result

The actions recorded in the audit logs are incomplete and confusing:
- No records at all for add and remove, although the actions are listed in the options.
- When the integration is created, there are three actions: `sentry-app.add`, `sentry-app.install` and `internal-integration.create`. When the integration is removed only `sentry-app.remove` is created. It is not big issue, but if there are 3 actions for creating, i expect to see the opposite three actions when the integration is removed.

![Screenshot 2023-06-30 at 11 23 08](https://github.com/getsentry/sentry/assets/64906376/d8f8e30f-6e2d-403e-9e16-63d14bd2bcdf)

Available options:
![Screenshot 2023-06-30 at 11 25 56](https://github.com/getsentry/sentry/assets/64906376/af1daf64-0c6f-418e-8593-23b12df1dca6)

Solutions:
- Properly record the `internal-integration.add-token` and `internal-integration.remove-token` actions in the logs. Include the scopes used when adding a new token.
- Add a record for `internal-integration.edit-token` listing any scope change when the permissions of an internal integration are change.
- Add `internal-integration.edit` action that record other changes in the integration (name, webhooks, alert-action)
- Add the two "missing" `internal-integration.remove` action and record it.

### Product Area

Settings - Integrations

### Link

_No response_

### DSN

_No response_

### Version

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.