getsentry / getsentry/sentry

Disable editing an upserted monitor

Open
#49,264 8 comments 0 reactions 1 assignee Claimed by @evanpurkhiser View on GitHub
Product Area: Crons
Dominant language
Python
Stars
44.8k
Forks
4.9k
Avg merge
1d 5h
Merged PRs (30d)
624

Description

Currently when a monitor is receiving checkins with monitor config being upserted, you can NOT edit the monitors configuration, as changes will just be overwritten.

An ideal solution here would be to track a `using_upserts` as part of the monitor object, this would allow us to:

* Show an indicator in the UI that the monitor is being configured via upsert. (also ideal would be to have a `created via upsert` https://github.com/getsentry/sentry/issues/49274)
* Disallow editing of the monitor configuration when it's being actively upserted.

If a monitor checkin comes in without a monitor config we can remove the `using_upsert` label.

Requires https://github.com/getsentry/sentry/issues/46227

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.