getsentry / getsentry/sentry

Apply CODEOWNERS rules taking into account the stack trace order

Open
#47,216 10 comments 15 reactions 0 assignees View on GitHub
Improvement Product Area: Issues Sync: Jira
Dominant language
Python
Stars
44.8k
Forks
4.9k
Avg merge
1d 5h
Merged PRs (30d)
624

Description

### Problem Statement

If the stack trace contains files owned by different teams according to CODEOWNERS, the issue should be assigned to the owner of the file which is closest to the error in the stack trace (at the top of the stack). For this, one could evaluate CODEOWNERS on against each file in the stack trace, instead of evaluating against the entire stack trace.

**Context**
Currently, CODEOWNERS rules are applied top to bottom against the entire stack trace. The bottom-most rule that matches any file in the stack trace is the one that is applied. One can try to sort CODEOWNERS from more generic to more specific modules / files, but for big projects it is extremely hard to get this right and maintain (maybe there is even no solution, and the "right" order depends function being called).

### Solution Brainstorm

*No response*

┆Issue is synchronized with this [Jira Improvement]() by [Unito]()

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.