getsentry / getsentry/sentry

Slack Integration: Automatic parsing of a channel name via link_names may lead to incorrect notification

Open
#42,335 2 comments 0 reactions 0 assignees View on GitHub
Metrics
Dominant language
Python
Stars
44.8k
Forks
4.9k
Avg merge
1d 5h
Merged PRs (30d)
624

Description

### Environment

self-hosted ([https://develop.sentry.dev/self-hosted/]())

### Version

22.3.0

### Link

*No response*

### DSN

*No response*

### Steps to Reproduce

1. Create private slack channel named `#1`
2. Trigger an exception with message `array_splice(): Argument #1 ($array) must be of type array, int given`

### Expected Result

Notification with text `array_splice(): Argument #1 ($array) must be of type array, int given` is received

### Actual Result

Automatic parsing happens due to `link_names` option enabled, and notification is displayed as `array_splice(): Argument private channel ($array) must be of type array, int given`

![image](https://uploads.linear.app/3ed206af-f87a-40aa-82a0-150bf83e43e6/38cf1d9e-ffc4-4a5e-91d3-9c406ddf9876/7558b434-5ef5-4a30-91df-96e1b2644b56?signature=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJwYXRoIjoiLzNlZDIwNmFmLWY4N2EtNDBhYS04MmEwLTE1MGJmODNlNDNlNi8zOGNmMWQ5ZS1mZmM0LTRhNWUtOTFkMy05YzQwNmRkZjk4NzYvNzU1OGI0MzQtNWVmNS00YTMwLTkxZGYtOTZlMWIyNjQ0YjU2IiwiaWF0IjoxNzY5MjEwNzY2LCJleHAiOjE4MDA3ODEzMjZ9.pl8_XJ7kPieNm04uGMnTmUDzBsyKxugB73WFhOmJZ6s)

There is another issue related to `link_names` option [https://github.com/getsentry/sentry/issues/19271]() and simply changing `link_names` to `0` may break mentioned workaround in that issue for anyone using it.

Slack Recommendations: [https://api.slack.com/reference/surfaces/formatting#automatic-parsing__why-you-should-consider-disabling-automatic-parsing]()

We want to define a set of [lightweight metrics]() that SDKs can automatically collect for e.g. framework, language or platform, focusing only on signals that **do NOT overlap with Tracing**. Ideally these metrics should give a quick sense of app or runtime health, … while deeper investigation will still rely on traces or profiles.

Examples**:**

* Node.js runtime metrics (e.g., event loop delay, heap usage)
* Prisma-related metrics in Next.js
* Mobile CPU / memory usage to help surface potential ANRs or app hangs

---

**Candidate Metrics (add more below)**

* …

*(please also add ideas, questions or examples in comments)*

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.