getsentry / getsentry/sentry

Seer repo setup lacks clear permission error

Open
#122,231 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Bug
Dominant language
Python
Stars
44.8k
Forks
4.9k
Avg merge
21h 23m
Merged PRs (30d)
607

Description

During Seer repo setup / Code Review enablement, users without org:write (Member, Billing, team-only admin) can reach the flow but do not get an explicit error that they cannot add or enable a repo because of role.

A customer hit this and only guessed permissions after the fact: they expected an error like "you can't add a repo because you are not an admin," but none appeared.

Verified behavior

  • Org Seer settings writes are gated by org:write via useCanWriteSettings() (static/app/utils/seer/useCanWriteSettings.ts)
  • Code Review toggles disable without that scope (static/app/components/seer/repoTable/seerRepoTableRow.tsx)
  • Settings pages can show OrganizationPermissionAlert ("only owner or manager"), but that message is not clearly surfaced in the setup path itself
  • Backend write for repo Code Review settings is PUT /organizations/.../repos/settings/ with OrganizationIntegrationsPermission (src/sentry/integrations/api/endpoints/organization_repository_settings.py)

Impact
Non-manager/owner users may think Seer repo setup is broken rather than blocked by role, and try admin accounts without a product-side explanation.

Roles that cannot write org Seer repo settings

  • Member
  • Billing
  • Team Admin alone (no Manager/Owner org role)

Roles that can

  • Manager
  • Owner

Requested by colin.kawai.

--

View Junior Session [Sentry]

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with static/app/utils/seer/useCanWriteSettings.ts and static/app/components/seer/repoTable/seerRepoTableRow.tsx, then trace the Seer repo setup flow and its OrganizationPermissionAlert usage. The work is complete when users lacking org:write receive a clear explanation that their role cannot add or enable a repository, while authorized users retain the existing setup flow.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, typescript
Domain
authorization, backend, frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.