getsentry / getsentry/sentry

Metric alert MS Teams recovery/resolved notification not sent after workflow-engine migration

Open
#119,087 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Bug Waiting for: Product Owner
Dominant language
Python
Stars
44.8k
Forks
4.9k
Avg merge
21h 23m
Merged PRs (30d)
607

Description

Environment

SaaS (https://sentry.io/)

Steps to Reproduce
  1. A metric alert with a Microsoft Teams action, created before the workflow-engine ("Monitors") migration.
  2. After the org is migrated to the new system, let the alert trigger (Critical) and then return to normal.
  3. Watch the Teams channel.
Expected Result

Teams gets both the trigger notification and the recovery/resolved notification, as it did before migration.

Actual Result

Teams gets the trigger notification but never the recovery one. The incident resolves in-product; only the Teams recovery message is missing. On the affected alert, the Teams action's condition group has the escalation condition (issue_priority_greater_or_equal) but is missing the paired de-escalation condition (issue_priority_deescalating). Both are meant to be created together during migration and the action is attached to the group, so it should fire in both directions. Editing the rule doesn't restore the missing condition. A customer reported recovery messages stopping on a single date, consistent with their migration rollout. Related area: ISWF-2785.

Product Area

Alerts

Link

No response

DSN

No response

Version

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the workflow-engine migration for metric alert Microsoft Teams actions, focusing on how the action's condition group is built. Reproduce the migration scenario with a pre-migration alert, then verify that both escalation and de-escalation conditions exist and that recovery notifications are delivered after the alert resolves.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend, observability-sre
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.