Metric alert equation edits leave a stale rule name and no warning when an aggregate's tag filter is removed
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 44.8k
- Forks
- 4.9k
- Avg merge
- 21h 23m
- Merged PRs (30d)
- 607
Description
Environment
SaaS (https://sentry.io/)
Steps to Reproduce
- Create a metric alert using an equation with two aggregates: aggregate A filtered by a tag (e.g.
result:success) and aggregate B with no tag filter. - Save. The rule name reflects the original equation (one aggregate with the tag, one without).
- Edit the equation to remove the tag filter from aggregate A, so both aggregates are now identical.
- Save the edit.
Expected Result
Either the details view reflects the current equation after the edit, or the UI clearly flags that the edit changed what is measured (a tag was removed, collapsing two aggregates into the same value), so the user can confirm the alert still measures what they intend.
Actual Result
- The details view keeps showing the original equation (the tag still appears in the name) while the edit view shows the updated equation (tag removed). The two views disagree.
- Rule names are not regenerated after creation, so the displayed name no longer matches the active query. Hovering the chart no longer surfaces the removed tag, and the two aggregates now resolve to the same value.
- No warning or visual cue tells the user the edit changed what the alert measures.
Product Area
Alerts
Link
No response
DSN
No response
Version
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the metric alert edit and details views described in the reproduction, including where the equation and rule name are persisted and rendered. Done means both views reflect the edited equation and the interface clearly warns when removing a tag filter changes the measured values.
Written by the indexing model from the issue text.
Assessment
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100