getsentry / getsentry/sentry

[grouping] Handle trying to save bad rules more gracefully

Open
#112,486 1 comment 0 reactions 0 assignees View on GitHub
Component: Grouping GitHub Team: issue-detection-backend
Dominant language
Python
Stars
44.8k
Forks
4.9k
Avg merge
21h 10m
Merged PRs (30d)
635

Description

- Investigate what actually comes back on the FE when you try to save bad rules. We could probably handle this better/give the user better information about what's wrong.
- Right now trying to save bad rules causes an error in Sentry, which probably isn't necessary.

Example sentry error (key error when trying to parse the bad enhancement rule, because the matcher isn't one we recognize): https://sentry.sentry.io/issues/7395241875/events/564314b44c5049b69762dadb2bc56307/

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the attempt to save an invalid enhancement rule and inspect what the frontend receives, using the linked Sentry event as context for the unrecognized matcher error. Done means invalid rules produce useful information for the user without generating an unnecessary Sentry error.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend, frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.