getsentry / getsentry/sentry

Flaky test: tests/sentry/api/serializers/test_rule.py::WorkflowRuleSerializerTest::test_generate_rule_conditions_filters

Open
#108,913 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

flaky-test Tests
Dominant language
Python
Stars
44.8k
Forks
4.9k
Avg merge
21h 23m
Merged PRs (30d)
607

Description

Failing test: tests/sentry/api/serializers/test_rule.py::WorkflowRuleSerializerTest::test_generate_rule_conditions_filters
Sentry sha: 4a8dadc9c184ad93a761561c5f57437a29cd3300
Run: https://github.com/getsentry/sentry/actions/runs/22283663167

tests/sentry/api/serializers/test_rule.py:263: in test_generate_rule_conditions_filters
    assert conditions == serialized_rule["conditions"]
E   assert [{'id': 'sent... unresolved'}] == [{'id': 'sent...ls bar", ...}]
E     
E     At index 0 diff: {'id': 'sentry.rules.conditions.tagged_event.TaggedEventCondition', 'match': 'eq', 'value': 'bar', 'key': 'foo', 'name': "The event's tags match foo equals bar"} != {'id': 'sentry.rules.conditions.reappeared_event.ReappearedEventCondition', 'name': 'The issue changes state from archived to escalating'}
E     
E     Full diff:
E       [
E     +     {
E     +         'id': 'sentry.rules.conditions.tagged_event.TaggedEventCondition',
E     +         'key': 'foo',
E     +         'match': 'eq',
E     +         'name': "The event's tags match foo equals bar",
E     +         'value': 'bar',
E     +     },
E           {
E               'id': 'sentry.rules.conditions.reappeared_event.ReappearedEventCondition',
E               'name': 'The issue changes state from archived to escalating',
E           },
E           {
E               'id': 'sentry.rules.conditions.regression_event.RegressionEventCondition',
E               'name': 'The issue changes state from resolved to unresolved',
E           },
E     -     {
E     -         'id': 'sentry.rules.conditions.tagged_event.TaggedEventCondition',
E     -         'key': 'foo',
E     -         'match': 'eq',
E     -         'name': "The event's tags match foo equals bar",
E     -         'value': 'bar',
E     -     },
E       ]

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running tests/sentry/api/serializers/test_rule.py::WorkflowRuleSerializerTest::test_generate_rule_conditions_filters at Sentry sha 4a8dadc9c184ad93a761561c5f57437a29cd3300. Inspect the failure around line 263 and the serialized condition ordering shown in the report. Done means the test passes reliably across repeated runs without changing its intended condition coverage.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing-qa
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.