getsentry / getsentry/sentry

Objc exceptions with no in-app frames group poorly

Open
#102,187 5 comments 0 reactions 1 assignee Claimed by @lobsterkatie View on GitHub
Product Area: Issues
Dominant language
Python
Stars
44.8k
Forks
4.9k
Avg merge
22h 21m
Merged PRs (30d)
586

Description

### Environment

SaaS (https://sentry.io/)

### Steps to Reproduce

https://dropbox.sentry.io/issues/5135362741/events/f9b8e7ac1aa94c56a3283501d358654f/?project=4505546600087552

Here's an example of the issue. Note the group has many different crashes with different, unrelated traces. Grouping shows it's grouping on `objc_exception_throw` which is not in-app. It's not a good piece of context, really, especially since the exception type already indicates a thrown exception.

I think this should probably be changed at the Sentry level.

### Expected Result

I'd like these exceptions to either:
1. Group by message
2. Group by out-of-app stack frames which are actually relevant to the issue.

When I added the following rule to our grouping rules, it seems to have resulted in group by message for these problematic groups at the cost of regrouping a lot of other stuff. https://dropbox.sentry.io/issues/6978111173/?project=4505546600087552

```
stack.function:objc_exception_throw -group
```

### Actual Result

The issue is over-grouped, meaning there are many unrelated bugs in one group. Anything without in-app frames that also matches the exception type is all in one group.

### Product Area

Ingestion and Filtering

### Link

https://dropbox.sentry.io/issues/5135362741/events/f9b8e7ac1aa94c56a3283501d358654f/?project=4505546600087552

### DSN

_No response_

### Version

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.