getsentry / getsentry/sentry-react-native

Sentry wizard install into bare react-native project breaks use of react-native-version because of code added to project.pbxproj

Open
#3,888 2 comments 1 reaction 0 assignees View on GitHub
Errors Improvement React-Native
Dominant language
TypeScript
Stars
1.8k
Forks
366
Avg merge
1d 9h
Merged PRs (30d)
89

Description

**OS:**

- [ ] Windows
- \[ X\] MacOS
- [ ] Linux

**Platform:**

- \[ X\] iOS
- [ ] Android

**SDK:**

- \[X \] `@sentry/react-native` (>= 1.0.0)
- [ ] `react-native-sentry` (<= 0.43.2)

**SDK version:** 0.0.0

`react-native` version: 0.0.0

**Are you using Expo?**

- [ ] Yes
- \[X \] No

**Are you using **[**sentry.io**]()** or on-premise?**

- \[ X\] [sentry.io]() (SaaS)
- [ ] on-premise

---

**I have the following issue:**

The sentry install wizard updated my project.pbxproj file and made it unparseable by react-native-version

**Previous bits**

```
shellScript = "set -e\n\nWITH_ENVIRONMENT=\"../node_modules/react-native/scripts/xcode/with-environment.sh\"\nREACT_NATIVE_XCODE=\"../node_modules/react-native/scripts/react-native-xcode.sh\"\n\n/bin/sh -c \"$WITH_ENVIRONMENT $REACT_NATIVE_XCODE\"\n";
```

**New (and unparse-able bits) result:**

```
shellScript = "set -e\n\nWITH_ENVIRONMENT=\"../node_modules/react-native/scripts/xcode/with-environment.sh\"\nREACT_NATIVE_XCODE=\"../node_modules/react-native/scripts/react-native-xcode.sh\"\n\n/bin/sh -c \"$WITH_ENVIRONMENT \\\"/bin/sh ../node_modules/@sentry/react-native/scripts/sentry-xcode.sh $REACT_NATIVE_XCODE\\\"\"\n";
```

**Error from react-nativer-version**

```
[RNV] SyntaxError: Expected "\"", "\\'", "\\\"", "\\n", or [^\\"] but "\\" found.
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.