getsentry / getsentry/sentry-python

Improve Quart Tests

Open
#3,044 0 comments 0 reactions 0 assignees View on GitHub
Component: Tests Improvement Integration: Quart Python Quality Improvement
Dominant language
Python
Stars
2.2k
Forks
669
Avg merge
1d 1h
Merged PRs (30d)
213

Description

Our quart tests failed to detect that the Quart integration was completely broken. We should improve them so that they would have detected the failures in the below situation:

> It is very surprising that our test suite did not detect that this integration was completely broken. Perhaps, this is a limitation of the Quart `test_client` we use in testing. We should certainly add tests to make sure we do not break in this way again, but that can likely be done later, most important is to quickly fix the broken integration ASAP

_Originally posted by @szokeasaurusrex in https://github.com/getsentry/sentry-python/issues/3043#issuecomment-2093308286_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.