getsentry / getsentry/sentry-php

Consider Separate flow for Spans Events

Open
#1,954 1 comment 0 reactions 1 assignee Claimed by @Litarnus View on GitHub
PHP Spans Task
Dominant language
PHP
Stars
1.9k
Forks
474
Avg merge
2d 3h
Merged PRs (30d)
8

Description

Instead of using `applyToEvent` for every type, we can split them by type.

This would help in a few ways:

* More clarity what each type does and what data it needs
* Prevents that data is accidentally attached to wrong types (e.g. tags on logs)
* We could have different Event types with their own data instead of one big class with the union of all fields
* (theoretical) performance gains by reducing the number of type checks and data copy operations

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.