getsentry / getsentry/sentry-java

File I/O Instrumentation with OkHttp Cache enabled

Open
#4,566 7 comments 0 reactions 0 assignees View on GitHub
Android Feature Spans
Dominant language
Kotlin
Stars
1.4k
Forks
478
Avg merge
2d 23h
Merged PRs (30d)
67

Description

### Problem Statement

When I enabled [caching]() in the OkHttp client and activated File I/O Sentry instrumentation, I observed that the `file.write` span always ends with a `deadline_exceeded` status. This occurs due to the way OkHttp's `DiskLruCache` manages the journal file internally - it keeps the *journalWriter* open until explicitly closed.

Image

Sentry SDK: `8.13.2`
Sentry Gradle Plugin: `5.8.0`

### Solution Brainstorm

Ideally, we want the span to be properly closed each time cached data is flushed (written). Perhaps the Sentry SDK could handle this differently if the File I/O operation originates from the OkHttp cache. Alternatively, it would be beneficial if we could filter this span out, preventing its duration from contributing to the total `ui.load` time.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.