getsentry / getsentry/sentry-go

http.Request be changed to interface to avoid extra conversion for fasthtttp or hertz.

Open
#757 1 comment 0 reactions 0 assignees View on GitHub
Feature Go
Dominant language
Go
Stars
1.1k
Forks
262
Avg merge
1d 48m
Merged PRs (30d)
7

Description

## Summary

Hertz has a lot of users currently using sentry, some of them are sensitive to interface latency, we found that sentry-go only supports setting http.Request but not hertz's Request, and we need an additional conversion.

## Motivation

If it can be changed to interface, we can remove this conversion, bringing latency and CPU performance gains.
It may not be an interface, or there may be other options that don't require the conversion of http.Request.

## Additional Context

- hertz-sentry: https://github.com/hertz-contrib/hertzsentry
- Conversion Logic :https://github.com/hertz-contrib/hertzsentry/blob/main/hertzsentry.go#L71
![image](https://github.com/getsentry/sentry-go/assets/97824201/4cd6d07a-a689-403e-bd47-ec52dce5ac00)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.