getsentry / getsentry/sentry-go

Logrus hook prints error if event has been dropped

Open
#578 3 comments 0 reactions 0 assignees View on GitHub
Errors Go Good First Issue Improvement
Dominant language
Go
Stars
1.1k
Forks
262
Avg merge
1d 48m
Merged PRs (30d)
7

Description

When using the logrus hook to send logs to sentry, the following line is printed everytime the hook is triggered but the event is dropped (e.g. by using `BeforeSend`):

```
Failed to fire hook: failed to send to sentry
```

The log is triggered by [this particular error]().
I think this error should not be thrown at all since it's a valid scenario to drop sentry events client-side.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.