getsentry / getsentry/sentry-dotnet

DataCollection phase 2: migrate redact cascade and HTTP failed-request handler

Open
#5,429 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

.NET Feature
Dominant language
C#
Stars
770
Forks
250
Avg merge
2d 22h
Merged PRs (30d)
51

Description

Part of #5420. Phase 2 — behavior-neutral consumer migration.

Migrate the redaction cascade and the HTTP failed-request handler to the resolved config:

  • src/Sentry/SentryClient.cs:234-237 / :431-434 — .Redact() cascade currently triggered by SendDefaultPii == false (events, transactions, spans, breadcrumbs → URL userinfo redaction via PiiExtensions.RedactUrl).
  • src/Sentry/SentryHttpFailedRequestHandler.cs:81-92 — URL (path-only vs AbsoluteUri), request/response cookies and headers → gate on UrlQueryParams, Cookies, HttpHeaders.Request/Response behaviors with the shared filter utility.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the referenced sections in src/Sentry/SentryClient.cs and src/Sentry/SentryHttpFailedRequestHandler.cs, then inspect the resolved configuration and shared filter utility from parent issue #5420. Verify the redaction cascade and failed-request URL, cookie, and header handling use the specified behaviors without changing behavior, and run the relevant .NET test suite.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
backend, security
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.