getsentry / getsentry/sentry-dotnet

Look at deprecating DefaultTags (next major release)

Open
#5,225 1 comment 0 reactions 0 assignees View on GitHub
.NET Next Major Task
Dominant language
C#
Stars
770
Forks
248
Avg merge
3d 4h
Merged PRs (30d)
49

Description

>> I don't know what the grand design here was, and why tags are not getting applied to the scope instead.

It may be because we don't currently provide any simple mechanism to initialise the 'Root' scope (when not in Global mode).

> Should we follow-up on that refactoring now,

In terms of setting DefaultTags via some other mechanism than the enricher, I can't see any urgent need/benefit to doing that.

If we could replace DefaultTags with an easy way to initialise the RootScope, that would probably be more powerful/flexible since it would allow SDK users to set default all kinds of things (not just tags). Removing DefaultTags sounds like a breaking change... so I don't think we want to do that immediately. Maybe something that we could do for the next major (if .net 11 isn't too painful to upgrade to).

_Originally posted by @jamescrosswell in https://github.com/getsentry/sentry-dotnet/pull/5214#discussion_r3217600206_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.