getsentry / getsentry/sentry-dotnet
Change ArgumentOutOfRangeException to ArgumentException in DSC
- Dominant language
- C#
- Stars
- 770
- Forks
- 248
- Avg merge
- 3d 4h
- Merged PRs (30d)
- 49
Description
> Hmmm .... not sure if `ArgumentOutOfRangeException` is the correct exception here, as it's usually used when numeric values are greater than or less than expected ... maybe just `ArgumentException` ... but I'm not really answering the question, aren't I?!
We could change that... I think the traceId is essentially a GUID and you get an out of range if this is empty (i.e. all zeros)... if you squint, a guid is kind of a number but you have to squint 😜 Not really related to this PR however, since that code was added ages ago. We can create a new issue to address this if you think it's worth doing.
_Originally posted by @jamescrosswell in https://github.com/getsentry/sentry-dotnet/pull/4899#discussion_r2810525175_
Contributor guide
Assessment
This issue has not been assessed yet.