getsentry / getsentry/sentry-dotnet

Wrong parameter names for `string`-based overloads of `SentrySdk.StartTransaction`

Open
#4,903 3 comments 0 reactions 0 assignees View on GitHub
.NET Bug Good First Issue Needs Reproduction
Dominant language
C#
Stars
770
Forks
248
Avg merge
3d 4h
Merged PRs (30d)
49

Description

### Description

There seems to be an inconsistency / unexpected behavior in Sentry Traces when capturing via `string`-based overloads of `SentrySdk.StartTransaction`:
- `ITransactionTracer SentrySdk.StartTransaction(string name, string operation)`
- `ITransactionTracer SentrySdk.StartTransaction(string name, string operation, string? description)`

### Scenario `string, string`

```CSharp
using var transaction = SentrySdk.StartTransaction(
name: "my.transaction.name",
operation: "my.transaction.operation"
);
```

Results in:
- `span.description` = `my.transaction.name`
- `span.name` = `my.transaction.operation`
- `span.op` = `my.transaction.operation`

### Scenario `string, string, string?`

```CSharp
using var transaction = SentrySdk.StartTransaction(
name: "my.transaction.name",
operation: "my.transaction.operation",
description: "my.transaction.description"
);
```

Results in:
- `span.description` = `my.transaction.name`
- `span.name` = `my.transaction.operation`
- `span.op` = `my.transaction.operation`

Thanks @rodolfoBee.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.