getsentry / getsentry/sentry-dotnet

Improvements for auto memory dump collection

Open
#4,013 1 comment 1 reaction 0 assignees View on GitHub
.NET Improvement
Dominant language
C#
Stars
770
Forks
248
Avg merge
3d 4h
Merged PRs (30d)
49

Description

> we need to say what the threshold was. Was it X% etc?

![Image](https://uploads.linear.app/3ed206af-f87a-40aa-82a0-150bf83e43e6/e8f2a916-69ca-4623-845e-e3c89f5c9cf4/33bb689d-1b40-469e-ad67-a5d5cb9d69c1?signature=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJwYXRoIjoiLzNlZDIwNmFmLWY4N2EtNDBhYS04MmEwLTE1MGJmODNlNDNlNi9lOGYyYTkxNi02OWNhLTQ2MjMtODQ1ZS1lM2M4OWY1YzljZjQvMzNiYjY4OWQtMWI0MC00NjllLWFkNjctYTVkNWNiOWQ2OWMxIiwiaWF0IjoxNzc5MDcwNjk1LCJleHAiOjE4MTA2NDEyNTV9.hBjuNJ7ulIPttZYoF9Gp03nc0AkScWrpE3XNtIn0Vkc)

![Image](https://uploads.linear.app/3ed206af-f87a-40aa-82a0-150bf83e43e6/caa079d1-8256-4da6-b2e8-ae6b7127348c/da80128f-0887-4da5-88c4-ed753e6c6406?signature=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJwYXRoIjoiLzNlZDIwNmFmLWY4N2EtNDBhYS04MmEwLTE1MGJmODNlNDNlNi9jYWEwNzlkMS04MjU2LTRkYTYtYjJlOC1hZTZiNzEyNzM0OGMvZGE4MDEyOGYtMDg4Ny00ZGE1LTg4YzQtZWQ3NTNlNmM2NDA2IiwiaWF0IjoxNzc5MDcwNjk1LCJleHAiOjE4MTA2NDEyNTV9.PKgRiUcA86xKq8Q-rOZVB7Xcr3Rmkeq_Mte79t2-xPk)

> Not sure the stack trace helps here. Might be because of `AttachStacktrace`

![Image](https://uploads.linear.app/3ed206af-f87a-40aa-82a0-150bf83e43e6/88c4b99b-1249-4c78-9a02-d5f0802c8a64/b673f314-fcc3-4544-8302-5f3c782b2a8e?signature=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJwYXRoIjoiLzNlZDIwNmFmLWY4N2EtNDBhYS04MmEwLTE1MGJmODNlNDNlNi84OGM0Yjk5Yi0xMjQ5LTRjNzgtOWEwMi1kNWYwODAyYzhhNjQvYjY3M2YzMTQtZmNjMy00NTQ0LTgzMDItNWYzYzc4MmIyYThlIiwiaWF0IjoxNzc5MDcwNjk1LCJleHAiOjE4MTA2NDEyNTV9.xySx3tuaGhY-GEkKwRmV7h_DuT6nb4ZUFoHA9juGc_4)

[https://github.com/getsentry/symbol-collector/blob/6a67b120c928b1fea79ecf8c6365d3a3fa862eeb/src/SymbolCollector.Server/appsettings.json#L24]()

In that case nothing for us to do here. But it'll group everything based on the stack trace.
So we could at least set a `Fingerprint`, and group by "new \["MemoryDumpDetection", trigger.ToString()\]\`. So that we have different groups depending on what the trigger is. So if we change the trigger, we get a new issue.
And the trigger could be on the title/message too so it's easier to tell them apart.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.