getsentry / getsentry/sentry-dart

Move replay mask rendering to native

Open
#2,473 3 comments 3 reactions 0 assignees View on GitHub
Dart Explore > Replays Replays Tests
Dominant language
Dart
Stars
873
Forks
299
Avg merge
2d 7h
Merged PRs (30d)
30

Description

### Description

Now that both iOS and Android pass screenshot in-memory to native Bitmap, we could also do the mask rendering in native (at least for replay - error-screenshots would need to work as they do now).

In order to do that, we would store the output of `WidgetFilter` in the `Screenshot` class and and let the consumer decide whether they want to use the `RawRGBAData`+masks info (for replay native integrations) or compose the final PNG screenshot (for error screenshots.

This would also enable us to unit-test masks produced by `WidgetFilter`. If we wanted to, we could test the native mask rendering with "golden file approach", i.e. comparing the generated image to an expected one.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.