getsentry / getsentry/sentry-cocoa

Refrain from overwriting the span status for unfinished spans

Open
#3,060 4 comments 0 reactions 0 assignees View on GitHub
Breaking-change Cocoa Spans
Dominant language
Swift
Stars
1.1k
Forks
418
Avg merge
2d 3h
Merged PRs (30d)
106

Description

### Description

### Problem Statement

As discussed in https://github.com/getsentry/sentry-java/issues/1690 unfinished spans should be sent, but their status should not be set to `deadline_exceeded`. The related Relay PR is https://github.com/getsentry/relay/pull/1690. The minimum required Relay version is [22.12.0](https://github.com/getsentry/relay/blob/master/CHANGELOG.md#22120), so we have to point this out in the changelog to inform self-hosted customers about this change.

### Solution Brainstorm

Don't overwrite the span status.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.