getsentry / getsentry/self-hosted

Incorrect bash expansions during cleanup

Open
#3,782 0 comments 0 reactions 0 assignees View on GitHub
Bug
Dominant language
Shell
Stars
9.6k
Forks
2k
Avg merge
1d 3h
Merged PRs (30d)
12

Description

I'll leave it as a note to myself or someone else.

It looks like incorrect bash expansion occurs somewhere in the install scripts.

Oldest log I found in gh actions is [this one](https://github.com/getsentry/self-hosted/actions/runs/15405463873/job/43347185410), but it's probable been here for ages.

Pasta time

```
Setting up error handling ...
☠️ Seeing FORCE=1, forcing cleanup.

Volume sentry-self-hosted_sentry-clickhouse-log Removing
Volume sentry-self-hosted_sentry-smtp-log Removing
Volume sentry-self-hosted_sentry-nginx-www Removing
Volume sentry-self-hosted_sentry-kafka-log Removing
Volume sentry-self-hosted_sentry-nginx-cache Removing
Volume sentry-self-hosted_sentry-vroom Removing
Volume sentry-self-hosted_sentry-secrets Removing
Volume sentry-self-hosted_sentry-smtp Removing
Volume sentry-self-hosted_sentry-clickhouse-log Removed
Volume sentry-self-hosted_sentry-smtp-log Removed
Volume sentry-self-hosted_sentry-kafka-log Removed
Volume sentry-self-hosted_sentry-smtp Removed
Volume sentry-self-hosted_sentry-secrets Removed
Volume sentry-self-hosted_sentry-nginx-cache Removed
Volume sentry-self-hosted_sentry-nginx-www Removed
Volume sentry-self-hosted_sentry-vroom Removed
yes: standard output: Broken pipe
yes: standard output: Broken pipe
Error response from daemon: get Error: no such volume
Skipped volume: Error
Error response from daemon: get in: no such volume
Skipped volume: in
Error response from daemon: get scripts/_lib.sh:50.: no such volume
Skipped volume: scripts/_lib.sh:50.
Error response from daemon: get 'grep: no such volume
Skipped volume: 'grep
Error response from daemon: get '^sentry-'': no such volume
Skipped volume: '^sentry-''
Error response from daemon: get exited: no such volume
Skipped volume: exited
Error response from daemon: get with: no such volume
Skipped volume: with
Error response from daemon: get status: no such volume
Skipped volume: status
Error response from daemon: get 1: no such volume
Skipped volume: 1
unknown shorthand flag: '>' in ->

Usage: docker volume rm [OPTIONS] VOLUME [VOLUME...]

Run 'docker volume rm --help' for more information
Skipped volume: ->
Error response from daemon: get scripts/reset.sh:main:4: no such volume
Skipped volume: ./scripts/reset.sh:main:4
unknown flag: -->

Usage: docker volume rm [OPTIONS] VOLUME [VOLUME...]

Run 'docker volume rm --help' for more information
Skipped volume: -->
Error response from daemon: get scripts/_lib.sh:reset:50: no such volume
Skipped volume: scripts/_lib.sh:reset:50
Error response from daemon: get Cleaning: no such volume
Skipped volume: Cleaning
Error response from daemon: get up...: no such volume
Skipped volume: up...
🙈 Running _unit-test/create-docker-volumes-test.sh ...
Detecting Docker platform
```

### Event ID

_No response_

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the cleanup failure from the linked GitHub Actions log, then inspect scripts/_lib.sh and scripts/reset.sh, especially the reported cleanup locations. Run _unit-test/create-docker-volumes-test.sh as a related check. Done means cleanup no longer interprets log text and shell expansion artifacts as Docker volume names.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, shell
Domain
devops, infrastructure
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.