getodk / getodk/web-forms

Error style in repeats and groups shouldn't have rounded corners

Open Beginner friendly
#918 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
38
Forks
22
PR merge metrics
No merged PRs in 30d

Description

Minor stylistic improvement...

When a field constraint is violated the field background is coloured red. When not in a repeat or group this is shown with subtly rounded corners which looks good. However when it _is_ in a repeat or group the question runs right up to the edge of the border of the group and the rounded corners don't look good.

Image

Remove the rounded corners on error blocks when a border exists, so it looks like this:

Image

NB: on the smallest screens the repeats and groups don't have a border so the error should be rounded again...

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the styles for error blocks and the repeat or group borders. Check the responsive behavior at the smallest screen size, then verify that error blocks lose rounded corners only when a border is present and retain them when the border is absent.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
72/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.