getodk / getodk/web-forms

Denying location permissions shows error banner for empty fields before form entry has begun

Open
#897 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
38
Forks
22
PR merge metrics
No merged PRs in 30d

Description

### Expected Behaviour

If geolocation fails for whatever reason you should see the error message for that but nothing else.

### Observed Behaviour

You also see the error message for any empty required fields even though you haven't had the chance to fill them in yet.

### Reproduction Steps

Form (XML or XLSX file): https://github.com/user-attachments/files/31522825/error-banner-test.xml

Steps:
1. Load the form
2. Deny geolocation permissions

### Screenshots or Videos

https://github.com/user-attachments/assets/c6cf2018-dc67-4aa5-bb6f-bf51d3ea3868

### Environment

- Browser version:
- OS:
- Web Forms version:

### Additional Context

I think we can improve the UI in additional ways...

1. I think the geolocation message should be in a separate element because the "view" button doesn't make sense, it's shown at a different time, etc.
1. It would be better for the message to be a warning not an error - it may not block the form submission

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by loading the linked XML form in Web Forms and reproducing the denied-geolocation flow. Trace where the geolocation failure and empty required-field messages are displayed together. Done means denying permission shows only the geolocation message before form entry, while required-field errors remain appropriate after interaction.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend, web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.