getodk / getodk/web-forms

Better align TypeScript type checking in web-forms, .vue modules

Open
#212 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
38
Forks
22
PR merge metrics
No merged PRs in 30d

Description

As I've been reviewing #183, trying a change I want to suggest produced a very surprising type for a destructured array member. What surprised me is that I expected it to be `string | undefined`, but it is not!

As it turns out, the TypeScript configurations in `@getodk/web-forms` are much less strict than throughout the rest of the project. We should make these consistent. We should also consider sharing a great deal more between configs so it's less likely for discrepancies like this to occur.

Contributor guide

No contributing guide indexed for this repository

Research direction

Inspect the TypeScript configurations in @getodk/web-forms and compare them with the configurations used throughout the rest of the project. Reproduce the destructured-array type-checking example from the issue, then make the configurations consistent and verify that the unexpected type difference is resolved.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
build-system, tooling
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.