getodk / getodk/collect

Using submission_url from instances.db might block uploading forms

Open
#3,496 3 comments 0 reactions 0 assignees View on GitHub
needs discussion
Dominant language
Kotlin
Stars
789
Forks
1.4k
Avg merge
4d 15h
Merged PRs (30d)
16

Description

#### Software and hardware versions
Collect v1.24.1 and older versions

#### Problem description
submission_url from instances.db is used to upload filled forms, that mean if a user downloads a form with a wrong submission_url and fills some form he is not able to upload them even after downloading a fixed form.

#### Steps to reproduce the problem
1. Create and download a form that contains a wrong submission_url
2. Fill and save some instances
3. Realize that you added a wrong submission_url
4. Update your form and download it again
5. Try to upload already saved forms

#### Expected behavior
Forms should be uploaded using the updated submission_url.

#### Other information
It might be an issue especially if GS is used because if someone accidentally remove his spreadsheet and creates it again he is blocked.

Contributor guide

Open the contributing guide

Research direction

Start by tracing how submission_url is read from instances.db and used during saved-form upload. Reproduce the described sequence with an outdated URL, then inspect the upload flow and related tests if present. Done means forms saved with an old URL can upload using the updated submission_url.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, kotlin
Domain
mobile
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.