getodk / getodk/central

Frontend does not reflect refresh if refresh canceled previous request

Open
#605 0 comments 0 reactions 0 assignees View on GitHub
frontend
Dominant language
JavaScript
Stars
226
Forks
235
Avg merge
2d 22h
Merged PRs (30d)
19

Description

#### Problem description

On the Submissions page and the entity Data page, if the refresh button is clicked, then the data is refreshed in the background. In other cases in which the data is refreshed, the table is removed while the request is in progress, e.g., after a filter is changed or after entities are uploaded. A background refresh does a few things differently compared to those requests:

- The refresh button shows a spinner.
- The button is disabled.
- A loading message is not shown.

However, those differences do not activate if the refresh button is clicked while the previous request for OData is in progress: the button does not change, and a loading message is shown.

#### Steps to reproduce the problem

I only manually confirmed that this was an issue on the entity Data page. However, I'm pretty sure that it's an issue on the Submissions page as well.

- Navigate to the entity Data page for an entity list with more than 250 entities.
- Scroll to the bottom of the table. This triggers a request for the next entities in the table.
- While that request is in progress, click the refresh button.
- Clicking the refresh button cancels the request for the next entities in the table: only the request triggered by the refresh button is now in progress. However, observe that the refresh button does not show a spinner and is not disabled, and observe that there is a loading message below the table.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.