getodk / getodk/central

Table row no longer matches filter

Open
#579 0 comments 0 reactions 0 assignees View on GitHub
frontend needs discussion
Dominant language
JavaScript
Stars
226
Forks
235
Avg merge
2d 22h
Merged PRs (30d)
19

Description

#### Problem description

From @dbemke on Slack:

> When I'm looking at the entities table with conflicts and I resolve a conflict via "Review parallel updates" the submission is still in the table (the filter possible conflicts is applied but I can see the submission without the conflict) and when I download matching entities csv the table is empty (I guess the filter of possible conflicts is applied correctly in the csv). I don't know if it's expected that the submission is shown in the table after resolving the conflict.

#### Steps to reproduce the problem

1. Create a conflict.
2. From the manin page or entities list click the conflict message.
3. When taken to the table with the conflict click "Review parallel updates” and mark the conflict as resolved.
4. In the table the submission is present without the conflict icon (there is one submission present).
5. Click "Download 1 matching entity”

#### Expected behavior

I think there are two issues here:

- What if anything should happen to a row of the table that no longer matches the filter?
- Regardless of what happens to the row, I do think that the count in the download button should stay up-to-date.

Similar questions come up for the submissions table, where you can filter on review state, then update a submission’s review state to one not selected for in the filter.

@issa-tseng wrote on Slack about what should happen to the row:

> i feel like ideally the row would stay but have some sort of different appearance that makes it clear it’s not in the filter anymore, or maybe it fades out and is removed slowly. but it would be jarring i think if on leaving the modal it’s gone already? maybe it’s not a big deal

> i would have said just cross out the no longer matching text but it’s not text lol

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.