getodk / getodk/central

Role name in success message

Open
#1,298 1 comment 0 reactions 0 assignees View on GitHub
frontend needs discussion
Dominant language
JavaScript
Stars
226
Forks
235
Avg merge
2d 22h
Merged PRs (30d)
19

Description

After a user is given a role (either sitewide or on a project), a success message is shown that mentions the role name. For example:

> Success! “Bob” has been given a Role of “Project Manager” on this Project.

This works well in English, but the role name ends up being incorrectly capitalized in French and Spanish. That's because we translate each role name only once: role names are used across components, so each role's corresponding message is defined in [`/src/locales/en.json`](/src/locales/en.json). In French, "Project Manager" is "Gestionnaire de projet", so the success message becomes:

> Succès ! "Bob" a reçu un rôle de "Gestionnaire de projet" dans ce projet.

However, "Gestionnaire de projet" should be lower case here.

I think we have a few options:

- Remove the role name from the success message. We could show "Success! “Bob” has been given a Role on this Project." without mentioning the role name.
- Make the role name lower case everywhere in French and Spanish. "Project Manager" is only translated once, so it could be translated in French as "gestionnaire de projet". It would be lower case in the dropdown.
- Translate the dropdown separately from the success message, translating each role twice.

I think I lean toward the first option, as that option seems simplest.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.