getodk / getodk/central

Remove or refactor FormGroup

Open
#1,293 0 comments 0 reactions 0 assignees View on GitHub
frontend refactor
Dominant language
JavaScript
Stars
226
Forks
235
Avg merge
2d 22h
Merged PRs (30d)
19

Description

Our `FormGroup` component corresponds to the Bootstrap `form-group` class. It is used when a `.form-group` has a corresponding `.form-label`. The component also implements functionality around the form control.

`FormGroup` worked well when we only used simple input elements for the form control. However, we now use `.form-group` and `.form-label` together with select elements, as well as the flatpickr input. That means that there are a few situations in which `.form-group` must be used, but `FormGroup` cannot be, which seems potentially confusing.

We could consider refactoring `FormGroup` so that it works with a variety of form controls. However, `FormGroup` does relatively little work outside of the form control, so it may also make sense to remove the component and go back to just using `.form-group` outside a component.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.