getlantern / getlantern/unbounded

Add a flag to prevent proxying through yourself?

Open
#72 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
57
Forks
1
Avg merge
20h 26m
Merged PRs (30d)
13

Description

During the 01/11/2023 group testing session, @myleshorton asked:

"are there guards against proxying through yourself if you're running both [the widget and the desktop client]?"

Answer: no, but there probably should be.

Looking to the far future -- in a world with true role agnosticism beyond the censored/uncensored binary, this feature would almost definitely be required, since every peer would be both a connectivity producer and a connectivity consumer.

One approach might entail adding a hash of peer IP address to genesis messages, so that peers can filter on that field when evaluating the suitability of connectivity advertisements.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files, tests, or entry points. Start by locating the widget and desktop client paths that handle proxying, connectivity advertisements, and genesis messages. Clarify whether the intended result is a flag, an address-hash check, or both, then define tests showing that a peer cannot select itself.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
networking
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.