getlantern / getlantern/unbounded
Test write errors in the egressConsumer workerFSM
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 57
- Forks
- 1
- Avg merge
- 20h 26m
- Merged PRs (30d)
- 13
Description
A hunch via code inspection:
In state 5 of the egressConsumer workerFSM, a write error will correctly close the WebSocket, exit the state, and terminate the worker's goroutine -- but it will leak the goroutine we fire off to execute the read loop.
T/F?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in client/go/egress_consumer.go at the state 5 write-error path around line 105 and the read loop launched around line 72. Trace the workerFSM and read-loop lifecycle, then add coverage for a write error. Done means the test establishes whether the read-loop goroutine is left running after the WebSocket closes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100